FINERACT-1981: Function Value using simple interest for EMI calculation - #3904
Merged
adamsaghy merged 1 commit intoMay 29, 2024
Conversation
adamsaghy
reviewed
May 28, 2024
Contributor
There was a problem hiding this comment.
previousFnValue can be final
alberto-art3ch
force-pushed
the
enhancement/loan_progressive_emi_calcs_fnvalue
branch
from
May 28, 2024 12:05
282db0d to
1705623
Compare
alberto-art3ch
force-pushed
the
enhancement/loan_progressive_emi_calcs_fnvalue
branch
from
May 28, 2024 13:10
1705623 to
5d3cb1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to calculate the monthly payment, we first need to calculate something called the Fn Value. We're going to be using simple interest. The Fn Value for simple interest is calculated by the following formula:
fn = 1 + fnValueFrom * rateFactorEndFINERACT-1981
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.