FINERACT-1971: Accrual for interest bearing loan with charge accrual based on submitted On Date fix - #3913
Merged
adamsaghy merged 1 commit intoJun 6, 2024
Conversation
adamsaghy
reviewed
Jun 2, 2024
Contributor
There was a problem hiding this comment.
isEmpty might be better for readability.
However I dont really like this method. There are 2 places you check whether accrual transaction date to be used or the charge due date. Would you mind merge the conditions into just one place? You need a date , the method should decide entirely what date to be retrieved and hence to be used.
ruchiD
force-pushed
the
FINERACT-1971-Accrual-charge-submittedOnDate-for-interest-bearing-loan
branch
from
June 3, 2024 10:10
2ea702c to
0615f62
Compare
adamsaghy
reviewed
Jun 3, 2024
…based on submitted On Date fix
ruchiD
force-pushed
the
FINERACT-1971-Accrual-charge-submittedOnDate-for-interest-bearing-loan
branch
from
June 3, 2024 15:50
0615f62 to
acc1edc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.