FINERACT-2181: Global configuration queries now return proper http codes - #4405
Conversation
|
@Cocoa-Puffs FINERACT-2081 was a story to cover minor changes in 1.11. Since this version of release process started, we cannot use this story anymore. Kindly use the https://issues.apache.org/jira/browse/FINERACT-2196 instead |
f8e1547 to
23faa22
Compare
Cocoa-Puffs
changed the title
1c4d44e to
88750c6
Compare
…ot found cases, added tests
88750c6 to
5204be3
Compare
| import org.junit.jupiter.api.Order; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| @Order(1) |
There was a problem hiding this comment.
Why do we need @Order? This isn't a good practice for tests because it breaks their atomicity and independence.
There was a problem hiding this comment.
This test broke non deterministically. When I pushed the branch the tests ran without problems, but that test failed on the pr. I have another branch in the works and on that branch the tests failed, but ran without errors on the pr.
I wrote to @adamsaghy about this and he suggested adding an order on that test so it would run first. Thereby minimizing the chance of the test failing due to the async validations and checks in it.
There was a problem hiding this comment.
There are exceptions, like this where the catch up functionality responsibility to pick up every loan that is considered behind (based on date) and run the COB on them till the current business date.
if these type of tests got executed in the middle of the integration tests or at the end there will be a lot of loan to be processed, so it make sense to do it early stage
3 participants
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.