Skip to content

FINERACT-2169: Account rules api refactor; - #4435

Merged
adamsaghy merged 1 commit into
apache:developfrom
VictorPavfurious:FINERACT-2169/Account_rules
Mar 14, 2025
Merged

FINERACT-2169: Account rules api refactor;#4435
adamsaghy merged 1 commit into
apache:developfrom
VictorPavfurious:FINERACT-2169/Account_rules

Conversation

@VictorPavfurious

Copy link
Copy Markdown
Contributor

Description

  1. Replace string req/responce to dto;
  2. Improve code styles;

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review whether the response data type and the swagger responses are matching or not!

Alternatively we can remove all the explicit swagger classes and let the system generate the swagger response based on the response data type!

@VictorPavfurious
VictorPavfurious force-pushed the FINERACT-2169/Account_rules branch from cf51f77 to 3481e43 Compare March 12, 2025 13:48
@VictorPavfurious
VictorPavfurious force-pushed the FINERACT-2169/Account_rules branch from 3481e43 to 4fca808 Compare March 12, 2025 16:01
@adamsaghy
adamsaghy merged commit 99f313e into apache:develop Mar 14, 2025
@VictorPavfurious
VictorPavfurious deleted the FINERACT-2169/Account_rules branch March 28, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants