FINERACT-2181: improve-assertj-assertions

[7ossam7atem1]

Description

• Replaced .size() assertions with hasSize()
• Used hasToString() for string comparisons
• Simplified assertions using satisfies() method
• Immediate return in createHolidayDTO()

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[adamsaghy]

@7ossam7atem1 Kindly use the appropriate PR title and commit message:
"FINERACT-XXXX: short description"

This is mandatory for each PR!

Is fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGeneratorTest.java the only class where these improvements make sense?

[adamsaghy]

@7ossam7atem1 Please change the commit message as well!

[7ossam7atem1]

@7ossam7atem1 Please change the commit message as well!

Done

[7ossam7atem1]

@7ossam7atem1 Kindly use the appropriate PR title and commit message: "FINERACT-XXXX: short description"

This is mandatory for each PR!

Is fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGeneratorTest.java the only class where these improvements make sense?

I'll look for other classes that may benefit from similar changes and update them