FINERACT-2315: Fix SMS Status Reports Error - #4786
Merged
Merged
Conversation
Pinchez25
force-pushed
the
fix/sms-status-reports
branch
from
June 19, 2025 07:17
218ff50 to
966672d
Compare
adamsaghy
requested changes
Jun 22, 2025
adamsaghy
left a comment
Contributor
There was a problem hiding this comment.
Please add test which covers correct behaviour!
Contributor
|
@Pinchez25 What's up here? |
Pinchez25
force-pushed
the
fix/sms-status-reports
branch
4 times, most recently
from
July 21, 2025 10:14
8e6b080 to
edbb836
Compare
Pinchez25
force-pushed
the
fix/sms-status-reports
branch
from
July 21, 2025 11:24
edbb836 to
4b67627
Compare
Pinchez25
force-pushed
the
fix/sms-status-reports
branch
from
July 21, 2025 12:11
4b67627 to
b49fdb4
Compare
galovics
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.