FINERACT-2326: Capitalized Income transaction template considering over applied amount when enabled - #4877
Merged
Conversation
alberto-art3ch
force-pushed
the
FINERACT-2181/capitalized-income-calculation-with-approved-over-applied-amount-enabled
branch
from
July 22, 2025 03:22
48df271 to
2c3eef1
Compare
alberto-art3ch
changed the title
alberto-art3ch
force-pushed
the
FINERACT-2181/capitalized-income-calculation-with-approved-over-applied-amount-enabled
branch
from
July 22, 2025 03:28
2c3eef1 to
0956bf9
Compare
alberto-art3ch
changed the title
Cocoa-Puffs
reviewed
Jul 22, 2025
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component | ||
| public final class LoanMaximumAmountValidator { |
Contributor
There was a problem hiding this comment.
I would not call this a validator as it doesn't really validate anything. Please rename it and maybe move it out of the serialization package as well.
Contributor
Author
There was a problem hiding this comment.
Done! I've renamed this class
Cocoa-Puffs
reviewed
Jul 22, 2025
| final BigDecimal maxAppliedAmount = getOverAppliedMax(loan); | ||
| final BigDecimal maxAppliedAmount = loanMaximumAmountValidator.getOverAppliedMax(loan); | ||
| if (newTotal.compareTo(maxAppliedAmount) > 0) { | ||
| baseDataValidator.reset().parameter("transactionAmount").failWithCode("exceeds.approved.amount", |
Contributor
There was a problem hiding this comment.
Should we consider changing the error code? We aren't really comparing the transaction amount to the approved amount in this case.
Contributor
Author
There was a problem hiding this comment.
I don't know, this is a part of legacy code, I've just change from the local method to the other class
Contributor
|
The description references FINERACT-2181, but since we have already released 1.12.0 it should reference FINERACT-2326. Same with the branch. |
adamsaghy
changed the title
Contributor
|
@alberto-art3ch Please rebase your PR! |
…er applied amount when enabled
alberto-art3ch
force-pushed
the
FINERACT-2181/capitalized-income-calculation-with-approved-over-applied-amount-enabled
branch
from
July 30, 2025 19:00
1e6c6f3 to
0d935c1
Compare
Contributor
Author
@adamsaghy PR rebased |
adamsaghy
deleted the
FINERACT-2181/capitalized-income-calculation-with-approved-over-applied-amount-enabled
branch
July 31, 2025 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need the calculations with CI to reflect the right amount even when the Allow approval / disbursal above loan applied amount setting enabled and look like that:
Disbursement + CI <= Approved (including over applied amount when enabled)FINERACT-2181
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.