Skip to content

FINERACT-2311: Buy down fee adjustment - portion fix - #4895

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:feature/FINERACT-2311-buy-down-fee-adjustment-portion-fix
Jul 28, 2025
Merged

FINERACT-2311: Buy down fee adjustment - portion fix#4895
adamsaghy merged 1 commit into
apache:developfrom
openMF:feature/FINERACT-2311-buy-down-fee-adjustment-portion-fix

Conversation

@magyari-adam

Copy link
Copy Markdown
Contributor

Description

Buy down fee adjustment transaction were not meant to have principal portion.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@magyari-adam
magyari-adam marked this pull request as ready for review July 28, 2025 13:05

@Cocoa-Puffs Cocoa-Puffs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamsaghy
adamsaghy merged commit 0698c4a into apache:develop Jul 28, 2025
39 checks passed
@adamsaghy
adamsaghy deleted the feature/FINERACT-2311-buy-down-fee-adjustment-portion-fix branch July 28, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants