You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made. (Not applicable — workflow change only)
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes. (Not applicable — no API change)
@Akshat-Soni02 Please change the commit message to match with the PR title: FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release
@Akshat-Soni02 Please change the commit message to match with the PR title: FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release
@Akshat-Soni02
Execution failed for task ':spotlessMiscCheck'.
The following files had format violations:
.github/workflows/publish-dockerhub.yml
@@ -41,7 +41,7 @@
··········else
············TAGS="${{·github.ref_name·}}"
··········fi
-··········
+
··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·
············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·
············-Djib.to.auth.***
Run './gradlew :spotlessApply' to fix these violations.
@Akshat-Soni02 Execution failed for task ':spotlessMiscCheck'.
The following files had format violations:
.github/workflows/publish-dockerhub.yml
@@ -41,7 +41,7 @@
··········else
············TAGS="${{·github.ref_name·}}"
··········fi
-··········
+
··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·
············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·
············-Djib.to.auth.***
Run './gradlew :spotlessApply' to fix these violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eases
Description
This PR updates the DockerHub publishing workflow (
publish-dockerhub.yml) to improve tag naming:developbranch → publish image with thelatesttag.1.*) → publish image with the version number only.developtag.This change makes the "Recent tags" dropdown on DockerHub more understandable for end users.
Checklist
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htmwith details of any API changes. (Not applicable — no API change)