Skip to content

FINERACT-2402: Replace delimiter : with = in kafka-server.env - #5134

Merged
meonkeys merged 1 commit into
apache:developfrom
Aman-Mittal:FINERACT-2402/kafka-server-env-changes
Oct 31, 2025
Merged

FINERACT-2402: Replace delimiter : with = in kafka-server.env#5134
meonkeys merged 1 commit into
apache:developfrom
Aman-Mittal:FINERACT-2402/kafka-server-env-changes

Conversation

@Aman-Mittal

@Aman-Mittal Aman-Mittal commented Oct 31, 2025

Copy link
Copy Markdown
Member

Description

Describe the changes made and why they were made.

Created PR after feedback from my previous PR: #5131

Although it is not necessary but using : in env variables may cause in older versions of docker compose. So replacing : to = as standard way of keeping .env file

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@Aman-Mittal
Aman-Mittal marked this pull request as ready for review October 31, 2025 17:07
@Aman-Mittal

Copy link
Copy Markdown
Member Author

@meonkeys This PR is for fixing delimiters.

@meonkeys
meonkeys self-requested a review October 31, 2025 17:18
@meonkeys

Copy link
Copy Markdown
Contributor

LGTM, thanks @Aman-Mittal . I'll merge once tests pass.

@meonkeys
meonkeys merged commit 8c3c44b into apache:develop Oct 31, 2025
33 checks passed
@Aman-Mittal
Aman-Mittal deleted the FINERACT-2402/kafka-server-env-changes branch January 25, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants