Skip to content

FINERACT-2326: Refractor redundant and some deprecated code as per new Java 21 style (Phase 2) - #5236

Merged
adamsaghy merged 1 commit into
apache:developfrom
Aman-Mittal:FINERACT-2326/Refactor-some-logical-codes
Dec 17, 2025
Merged

FINERACT-2326: Refractor redundant and some deprecated code as per new Java 21 style (Phase 2)#5236
adamsaghy merged 1 commit into
apache:developfrom
Aman-Mittal:FINERACT-2326/Refactor-some-logical-codes

Conversation

@Aman-Mittal

Copy link
Copy Markdown
Member

Description

The refactoring will be delivered through incremental pull requests, organized by phases (Phase 1, Phase 2, Phase 3, and so on). Each phase will be submitted only after the prior phase has been merged.

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@ComponentScan("com.acme.fineract.loan.job") })
@ComponentScan("com.acme.fineract.loan.cob")
@ComponentScan("com.acme.fineract.loan.processor")
@ComponentScan("com.acme.fineract.loan.job")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is not incorrect, but maybe this one is more readable:

@ComponentScan(basePackages = {
    "com.acme.fineract.loan.cob",
    "com.acme.fineract.loan.processor",
    "com.acme.fineract.loan.job"
})

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, Updated as suggested

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aman-Mittal
Aman-Mittal force-pushed the FINERACT-2326/Refactor-some-logical-codes branch from 92ddb41 to 8115875 Compare December 16, 2025 12:53
@adamsaghy
adamsaghy merged commit 4bfae04 into apache:develop Dec 17, 2025
@Aman-Mittal
Aman-Mittal deleted the FINERACT-2326/Refactor-some-logical-codes branch January 25, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants