FINERACT-2354: added e2e test for validation of re-aging with various interest handling is forbidden on written-off loan - #5240
Merged
adamsaghy merged 2 commits intoDec 19, 2025
Conversation
…interest handling is forbidden on written-off loan
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/reaging-after-write-off-should-be-forbidden
branch
2 times, most recently
from
December 18, 2025 11:58
0416ffb to
655b52d
Compare
ruzeynalov
marked this pull request as ready for review
December 18, 2025 14:43
Aman-Mittal
reviewed
Dec 18, 2025
| public void adminFailsToCreateReAgingTransactionWithError(final int statusCode, final String expectedError, final DataTable table) { | ||
| final PostLoansResponse loanResponse = testContext().get(TestContextKey.LOAN_CREATE_RESPONSE); | ||
| final long loanId = loanResponse.getLoanId(); | ||
|
|
Member
There was a problem hiding this comment.
PostLoansLoanIdTransactionsRequest reAgingRequest = setReAgeingRequestProperties(//
LoanRequestFactory.defaultReAgingRequest(), //
table.row(0), //
table.row(1) //
);
CallFailedRuntimeException exception = fail(
() -> fineractClient.loanTransactions().executeLoanTransaction(loanId, reAgingRequest, Map.of("command", "reAge")));
assertThat(exception.getStatus()).as(ErrorMessageHelper.dateFailureErrorCodeMsg()).isEqualTo(403);`
this code is being duplicated many times in this test file, is it possible if we can create a helper function so that we can reuse this multiple times for better maintainability?
Contributor
There was a problem hiding this comment.
good caught, thanks, gonna add such method
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/reaging-after-write-off-should-be-forbidden
branch
from
December 18, 2025 17:09
655b52d to
acd3958
Compare
adamsaghy
deleted the
FINERACT-2354/reaging-after-write-off-should-be-forbidden
branch
December 19, 2025 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.