Skip to content

FINERACT-2425: Tax component and Tax Group refactoring - #5273

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2425/tax-component-tax-group-refactoring
Jan 3, 2026
Merged

FINERACT-2425: Tax component and Tax Group refactoring#5273
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2425/tax-component-tax-group-refactoring

Conversation

@alberto-art3ch

Copy link
Copy Markdown
Contributor

Description

The Taxes module is one of the oldest functionality, and It has some issues, like:

  • typo issues,
  • the data readers are implemented with old logic

Then it is not useful then the APIs, write and read, are not working

FINERACT-2425

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Aman-Mittal Aman-Mittal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise seems ok, I did not reviewed it based on backward compatibility point of view

@bharathcgowda

Copy link
Copy Markdown

@adamsaghy could you please help in reviewing this PR when you get some time?

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit b7306f1 into apache:develop Jan 3, 2026
@adamsaghy
adamsaghy deleted the FINERACT-2425/tax-component-tax-group-refactoring branch January 3, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants