FINERACT-2425: Tax component and Tax Group refactoring - #5273
Merged
adamsaghy merged 1 commit intoJan 3, 2026
Merged
Conversation
Aman-Mittal
approved these changes
Dec 30, 2025
Aman-Mittal
left a comment
Member
There was a problem hiding this comment.
Code wise seems ok, I did not reviewed it based on backward compatibility point of view
|
@adamsaghy could you please help in reviewing this PR when you get some time? |
adamsaghy
deleted the
FINERACT-2425/tax-component-tax-group-refactoring
branch
January 3, 2026 00:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Taxes module is one of the oldest functionality, and It has some issues, like:
Then it is not useful then the APIs, write and read, are not working
FINERACT-2425
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.