FINERACT-2459: Refactor SmsReadPlatformServiceImpl to use Prepared Statements - #5407
Conversation
|
@Saifulhuq01 the PR and the commit doesn't follow the title conventions use "FINERACT-854: Use prepared statements instead of string concatenated SQL everywhere" squash and commit your changes because only 1 commit per PR is required. Maybe you should open a new Jira ticket on Apache Fineract jira for only one use case, because the title is "everywhere" and make sure the changes include a test. |
6dd293b to
13679eb
Compare
|
Jira Ticket: Created specific ticket FINERACT-2459. Squash: Squashed commits into a single commit with the new ID. Tests: Verified that existing integration tests cover this service. Ready for review. |
Hi @IOhacker, just a friendly bump on this. I have addressed the previous feedback (Squashed commits + JIRA ticket). Let me know if further changes are needed. |
|
LGTM |
Thanks for the review @IOhacker! Glad we could get this resolved. Looking forward to the merge. |
Description
Replaced potential SQL injection vulnerability in
SmsReadPlatformServiceImpl.javaby switching from String concatenation to Prepared Statements.Resolves FINERACT-2459
Changes
retrieveAllPendingto use?placeholders forstatus_enumandcampaign_id.List<Object>to pass parameters dynamically tojdbcTemplate.Checklist