FINERACT-2491: Refactor SavingsEnumerations to use switch expression

[Abdelrahman-358]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

Could you please add some test classes?

[Abdelrahman-358]

Could you please add some test classes?

Sure, I'll add the tests.

[Abdelrahman-358]

@IOhacker Tests added.

[Abdelrahman-358]

Hello @adamsaghy ,
Is this kind of refactoring considered valuable for the project? I’ve noticed several other classes with a similar pattern.

Since I currently have some available time, I’d like to focus on more impactful contributions to help me better understand the codebase. Could you please advise me on where I can contribute more effectively?

Thanks!

[adamsaghy]

Hello @adamsaghy , Is this kind of refactoring considered valuable for the project? I’ve noticed several other classes with a similar pattern.

Since I currently have some available time, I’d like to focus on more impactful contributions to help me better understand the codebase. Could you please advise me on where I can contribute more effectively?

Thanks!

Every contribution which makes the codebase more safe and effective or readable counts! :)

Based on your availability and appetite there are multiple areas where improvements are needed:

Bug tickets
https://issues.apache.org/jira/browse/FINERACT-2492?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20%20AND%20type%20%3D%20Bug%20%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

Code maintainability / readability
We have a great number of compilation warnings, due to various reasons. I believe at least half of them could be fixed quite easily and along this works, the codebase could became more safe and easier to maintain.

All the rest of the stories
https://issues.apache.org/jira/browse/FINERACT-2494?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

All the rest of the stories that are considered beginner friendly
https://issues.apache.org/jira/browse/FINERACT-2489?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20and%20labels%20IN%20(beginner-friendly%2C%20beginner%2C%20begineer%2C%20beginners%2C%20Beginner)%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

[Abdelrahman-358]

Hello @adamsaghy , Is this kind of refactoring considered valuable for the project? I’ve noticed several other classes with a similar pattern.
Since I currently have some available time, I’d like to focus on more impactful contributions to help me better understand the codebase. Could you please advise me on where I can contribute more effectively?
Thanks!

Every contribution which makes the codebase more safe and effective or readable counts! :)

Based on your availability and appetite there are multiple areas where improvements are needed:

Bug tickets https://issues.apache.org/jira/browse/FINERACT-2492?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20%20AND%20type%20%3D%20Bug%20%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

Code maintainability / readability We have a great number of compilation warnings, due to various reasons. I believe at least half of them could be fixed quite easily and along this works, the codebase could became more safe and easier to maintain.

All the rest of the stories https://issues.apache.org/jira/browse/FINERACT-2494?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

All the rest of the stories that are considered beginner friendly https://issues.apache.org/jira/browse/FINERACT-2489?filter=-1&jql=project%20%3D%20%22Apache%20Fineract%22%20and%20labels%20IN%20(beginner-friendly%2C%20beginner%2C%20begineer%2C%20beginners%2C%20Beginner)%20%20AND%20resolution%20%3D%20Unresolved%20order%20by%20created%20DESC

Thank you for the guidance!

I’ll start by looking into the compilation warnings and beginner-friendly issues to get more familiar with the codebase, then explore some bug tickets as well.