Skip to content

FINERACT-2542: Fix typos in GLClosures and AccountingRule Swagger descriptions - #5635

Merged
IOhacker merged 1 commit into
apache:developfrom
Suthankan1:FINERACT-2542-fix-swagger-typos
Mar 16, 2026
Merged

FINERACT-2542: Fix typos in GLClosures and AccountingRule Swagger descriptions#5635
IOhacker merged 1 commit into
apache:developfrom
Suthankan1:FINERACT-2542-fix-swagger-typos

Conversation

@Suthankan1

Copy link
Copy Markdown
Contributor

Description

Identified and corrected spelling errors in the Swagger-generated API documentation:

  • GLClosuresApiResource.java: Changed "identifer" to "identifier".
  • AccountingRuleApiResource.java: Changed "Journal entires" to "journal entries".

Associated Jira Ticket: https://issues.apache.org/jira/browse/FINERACT-2542

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made. (N/A - Documentation typo fix only)
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Copilot AI review requested due to automatic review settings March 16, 2026 16:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes typos in Swagger/OpenAPI descriptions for accounting-related API resources to improve generated API documentation.

Changes:

  • Corrected “Journal entires” → “journal entries” in AccountingRuleApiResource Swagger tag description.
  • Corrected “identifer” → “identifier” in GLClosuresApiResource Swagger tag description.
  • Added an extra blank line in ServerApplication.main() (appears unrelated to the PR description).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
fineract-provider/src/main/java/org/apache/fineract/ServerApplication.java Introduces an unrelated formatting-only change (extra blank line).
fineract-accounting/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResource.java Fixes typo in Swagger tag description (“journal entries”).
fineract-accounting/src/main/java/org/apache/fineract/accounting/closure/api/GLClosuresApiResource.java Fixes typo in Swagger tag description (“identifier”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 56 to 58
public static void main(String[] args) throws IOException {

configureApplication(new SpringApplicationBuilder(ServerApplication.class)).run(args);
@Suthankan1
Suthankan1 force-pushed the FINERACT-2542-fix-swagger-typos branch 2 times, most recently from d73ff5c to 797d6e9 Compare March 16, 2026 16:45
@Suthankan1
Suthankan1 force-pushed the FINERACT-2542-fix-swagger-typos branch from 797d6e9 to 2ec194a Compare March 16, 2026 17:20

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
IOhacker merged commit 5790a32 into apache:develop Mar 16, 2026
44 checks passed
@Suthankan1

Copy link
Copy Markdown
Contributor Author

Hi team! I noticed that the GitHub Actions build failed on Shard 7 during the merge, specifically on some EMI and Loan Capitalization integration tests. Since my changes only updated text strings in the Swagger annotations, I suspect this might be a flaky test run. Let me know if you would like me to close and reopen the PR to trigger a re-run, or if a maintainer can re-run the failed jobs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants