FINERACT-2542: Fix typos in GLClosures and AccountingRule Swagger descriptions - #5635
Merged
IOhacker merged 1 commit intoMar 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes typos in Swagger/OpenAPI descriptions for accounting-related API resources to improve generated API documentation.
Changes:
- Corrected “Journal entires” → “journal entries” in
AccountingRuleApiResourceSwagger tag description. - Corrected “identifer” → “identifier” in
GLClosuresApiResourceSwagger tag description. - Added an extra blank line in
ServerApplication.main()(appears unrelated to the PR description).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fineract-provider/src/main/java/org/apache/fineract/ServerApplication.java | Introduces an unrelated formatting-only change (extra blank line). |
| fineract-accounting/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResource.java | Fixes typo in Swagger tag description (“journal entries”). |
| fineract-accounting/src/main/java/org/apache/fineract/accounting/closure/api/GLClosuresApiResource.java | Fixes typo in Swagger tag description (“identifier”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
56
to
58
| public static void main(String[] args) throws IOException { | ||
|
|
||
| configureApplication(new SpringApplicationBuilder(ServerApplication.class)).run(args); |
Suthankan1
force-pushed
the
FINERACT-2542-fix-swagger-typos
branch
2 times, most recently
from
March 16, 2026 16:45
d73ff5c to
797d6e9
Compare
Suthankan1
force-pushed
the
FINERACT-2542-fix-swagger-typos
branch
from
March 16, 2026 17:20
797d6e9 to
2ec194a
Compare
Contributor
Author
|
Hi team! I noticed that the GitHub Actions build failed on Shard 7 during the merge, specifically on some EMI and Loan Capitalization integration tests. Since my changes only updated text strings in the Swagger annotations, I suspect this might be a flaky test run. Let me know if you would like me to close and reopen the PR to trigger a re-run, or if a maintainer can re-run the failed jobs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identified and corrected spelling errors in the Swagger-generated API documentation:
GLClosuresApiResource.java: Changed "identifer" to "identifier".AccountingRuleApiResource.java: Changed "Journal entires" to "journal entries".Associated Jira Ticket: https://issues.apache.org/jira/browse/FINERACT-2542
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!