FINERACT-1474: Remove hard-coded constants from ExternalCreditBureauTest - #5636
Conversation
55b4100 to
6414dbe
Compare
IOhacker
left a comment
There was a problem hiding this comment.
Hello, "ThitsaWorks" seems to be non neutral, it must be removed or replaced.
6414dbe to
ea97caa
Compare
ea97caa to
961609c
Compare
thank you for the feedback! i've refactored the code to replace all "Thitsaworks.." references with "ExternalCredit..." (including file name, classnames, method names) to ensure vendor neutrality. |
|
please make sure you run |
f41dc03 to
ac27d35
Compare
i did ran this, and came up with few failed test cases, specifically e2e , fixed them and saw "BUILD SUCCESS" now i've push commited again. |
ac27d35 to
78adba2
Compare
Description
This PR addresses Issue 1474 by refactoring the ExternalCreditBureauIntegrationWritePlatformServiceImplTest.java file and its implementation to remove hard-coded strings and magic numbers.
Changes Made
ExternalCreditBureauIntegrationWritePlatformService).CREDIT_BUREAU_ID,TEST_USERNAME,TEST_PASSWORD, andTEST_URL.setup()method and all@Testcases to utilize these constants.CreditReportWritePlatformServiceImpl) to align with the new neutral interface.Verification & Compliance
./gradlew :fineract-provider:test --tests "org.apache.fineract.infrastructure.creditbureau.service.ExternalCreditBureauIntegrationWritePlatformServiceImplTest"→ BUILD SUCCESSFUL../gradlew spotlessApply../gradlew rat→ PASSING.Checklist
GSoC 2026 Context:
This contribution is intended as evidence of competence for GSoC 2026.
Tag: gsoc-fineract-evidence