FINERACT-2675: Fix template endpoint - #6092
Merged
adamsaghy merged 1 commit intoJul 10, 2026
Merged
Conversation
AnvayKharb
force-pushed
the
fix/templates-api-response-shape
branch
2 times, most recently
from
July 5, 2026 18:08
0ff546b to
36681a5
Compare
AnvayKharb
force-pushed
the
fix/templates-api-response-shape
branch
2 times, most recently
from
July 5, 2026 19:20
6e2c6bc to
a23df1f
Compare
Contributor
|
@adamsaghy @vidakovic LGTM. @vidakovic I would like to know the reason it was changed before. |
Contributor
|
@AnvayKharb Please rebase |
AnvayKharb
force-pushed
the
fix/templates-api-response-shape
branch
from
July 10, 2026 05:13
1484ab7 to
7d6a78f
Compare
Contributor
Author
|
Please review @IOhacker @adamsaghy @vidakovic |
AnvayKharb
force-pushed
the
fix/templates-api-response-shape
branch
from
July 10, 2026 05:23
7d6a78f to
43e5c9e
Compare
AnvayKharb
force-pushed
the
fix/templates-api-response-shape
branch
from
July 10, 2026 06:39
43e5c9e to
96dea37
Compare
Contributor
|
@AnvayKharb Please make sure your commit is signed by GPG. I wont be able merge it till its done |
Contributor
Author
|
Hi @adamsaghy I've added the GPG key, please review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes FINERACT-2675 by restoring the template endpoint responses expected by the Mifos Web App.
Problem
After recent backend changes, the Templates API response contract changed:
GET /templatesreturned only template IDs, causing the Name, Entity, and Type columns to appear blank.GET /templates/{id}/templatereturned a raw template object instead of the wrapper containingtemplate,entities, andtypes, causing the Edit Template page to fail.Changes
GET /templates.GET /templates/{id}/templatecontaining:templateentitiestypesGET /templates/{id}.Testing
Verified by:
Fixes FINERACT-2675.