Skip to content

util: Add missing unlinkat to syscall sandbox - #24340

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2202-gcc12
Feb 15, 2022
Merged

util: Add missing unlinkat to syscall sandbox#24340
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2202-gcc12

Conversation

@maflcko

@maflcko maflcko commented Feb 14, 2022

Copy link
Copy Markdown
Member

This will be needed for g++-12 (after libstdc++6 12-20220206).

Steps to reproduce:

gdb --args ./src/bitcoind -sandbox=log-and-abort -regtest
./src/bitcoin-cli -regtest -named createwallet wallet_name=a descriptors=false
./src/bitcoin-cli -regtest stop

BT:

Thread 1 "b-shutoff" received signal SIGSYS, Bad system call.
0x00007ffff79564f7 in unlinkat () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0  0x00007ffff79564f7 in unlinkat () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff7cc7335 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2  0x00007ffff7cc94e3 in std::filesystem::remove_all(std::filesystem::__cxx11::path const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00005555559d4918 in wallet::BerkeleyEnvironment::Flush (this=0x7fffc4005160, fShutdown=<optimized out>) at /usr/include/c++/12/bits/fs_path.h:595
#4  0x000055555592c058 in wallet::StopWallets (context=...) at /usr/include/c++/12/bits/shared_ptr_base.h:1665
#5  0x00005555556617ca in Shutdown (node=...) at ./src/init.cpp:293
#6  0x000055555563ada6 in AppInit (argv=<optimized out>, argc=<optimized out>, node=...) at ./src/bitcoind.cpp:249
#7  main (argc=<optimized out>, argv=<optimized out>) at ./src/bitcoind.cpp:273

@fanquake fanquake added this to the 23.0 milestone Feb 14, 2022
@maflcko

maflcko commented Feb 14, 2022

Copy link
Copy Markdown
Member Author

Suspected change: gcc-mirror/gcc@ebf6175

@laanwj

laanwj commented Feb 14, 2022

Copy link
Copy Markdown
Member

Code review ACK fa45597

@maflcko
maflcko merged commit 444b6b3 into bitcoin:master Feb 15, 2022
@maflcko
maflcko deleted the 2202-gcc12 branch February 15, 2022 08:34
@bitcoin bitcoin locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants