Skip to content

ci: remove python3-setuptools from macOS build deps - #28932

Merged
fanquake merged 1 commit into
bitcoin:masterfrom
fanquake:drop_setuptools
Nov 24, 2023
Merged

ci: remove python3-setuptools from macOS build deps#28932
fanquake merged 1 commit into
bitcoin:masterfrom
fanquake:drop_setuptools

Conversation

@fanquake

Copy link
Copy Markdown
Member

Remove no-longer used python-setuptools.
Followup to #28432.
Related to #28845.

@DrahtBot

DrahtBot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28622 (build: use macOS 14 SDK (Xcode 15.0) by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot added the Tests label Nov 23, 2023

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0ffcc5b, I have reviewed the code and it looks OK.

@sedited sedited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0ffcc5b

@fanquake
fanquake merged commit c0196be into bitcoin:master Nov 24, 2023
@fanquake
fanquake deleted the drop_setuptools branch November 24, 2023 13:39
fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 30, 2023
Remove no-longer used libz-dev (from DMG compression).
Followup to bitcoin#28432.
Missed this in bitcoin#28932.
fanquake added a commit that referenced this pull request Dec 1, 2023
97d53e9 ci: remove libz-dev from macOS build deps (fanquake)

Pull request description:

  Remove no-longer used libz-dev (from DMG compression).
  Followup to #28432.
  Missed this in #28932.

ACKs for top commit:
  TheCharlatan:
    ACK 97d53e9

Tree-SHA512: ea4e46d83a11cfb0d77e7c5b370359864a026ca58e02de1a3d30458e4463dabd338db9546da63b782a7fa0ce199446c418fbfdfc400f3803b0ea9dd626aed42f
@bitcoin bitcoin locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants