fix(neo4j): hold the graph contract at the shared 2.0.0 baseline - #221
Merged
Conversation
SCHEMA_VERSION on the graph is a shared cross-analyzer number, not this analyzer's own. codeanalyzer-typescript states the rule on its own catalog -- "SCHEMA_VERSION moves only when every analyzer re-baselines together" -- and codeanalyzer-python has stayed at 2.0.0 throughout. This analyzer had drifted off it: 2.1.0 for the L4 SDG overlay, 2.2.0 for the repository-artifact layer, then 3.0.0 when `_module` was removed. The first two were additive over labels that 2.0.0 had already reserved, and the third claimed a MAJOR re-baseline no sibling had agreed to. None was anyone else's to undo, so the number goes back to 2.0.0 and the javadoc now says the rule out loud, so the next change here is recognizable as a cross-repo decision rather than a local one. The uncomfortable half is recorded in the code rather than papered over: removing `_module` IS breaking, and while this number stays put a consumer cannot detect that removal from the version alone. The answer is a coordinated re-baseline across all three analyzers, which is what the epic exists for -- not a unilateral bump here, which is exactly how the drift started. This also stops the graph reporting 3.0.0 while analysis.json reports 2.0.0 for the same analysis, from two fields that share the name `schema_version` and version different things. All three now read 2.0.0. No behaviour change: `_module` is still absent, :JCanNode still present, the prefix-scoped purge untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The graph
SCHEMA_VERSIONis a shared cross-analyzer number. codeanalyzer-typescript says so on its own catalog:This analyzer had drifted off it:
2.1.0 (L4 SDG overlay) and 2.2.0 (repository-artifact layer) were additive over labels 2.0.0 had already reserved. 3.0.0 — mine, in #220 — claimed a MAJOR re-baseline no sibling agreed to.
It also produced a second, uglier symptom: the graph reported
schema_version: 3.0.0whileanalysis.jsonreportedschema_version: 2.0.0for the same analysis, from two fields that share a name and version different things.3.0.0read as canonical schema v3, which does not exist.Fix
Back to
2.0.0, matching python. The javadoc now states the shared-line rule explicitly, so the next change here is recognisable as a cross-repo decision rather than a local one.The uncomfortable half, recorded rather than papered over
Removing
_moduleis breaking, and while this number stays put a consumer cannot detect that removal from the version alone. That is a real cost, and it is written into the code comment rather than left for someone to discover.The answer is a coordinated re-baseline across all three analyzers — which is what epic codellm-devkit/.github#50 exists for. Not a unilateral bump here, which is exactly how the drift started.
Verification
No behaviour change:
_modulestill absent (0 occurrences),:JCanNodestill present, the prefix-scoped purge from #220 untouched. Suite 509 tests, 1 failure — the pre-existing DockerCodeAnalyzerIntegrationTest.typescript remains at 2.1.0 and is now the outlier; that belongs to its own epic child (codeanalyzer-typescript#140).