feat(schema): body nodes and parameters carry their id in analysis.json - #180
Merged
Conversation
`BodyNode.id` is the global ordinal `<callable-id>@<local>` the Neo4j projection already merges `:PyBodyNode` on; `PyCallableParameter.id` is `<callable-id>@formal_in:<i>` for position i, the level-4 formal_in vertex that carries it. The `@`-rule now lives once in `schema/ids.py` and both `IdentityMap.global_id` and the projector delegate to it; a single stamp pass runs at the end of each body emitter (L1, L3, L4). Additive; schema_version and the graph contract are unchanged. Closes #176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176. Spec: codellm-devkit/.github
docs/design/specs/2026-09-05-body-node-id-in-analysis-json.md(epic codellm-devkit/.github#56).BodyNode.idis the global ordinal<callable-id>@<local>the Neo4j projection already merges:PyBodyNodeon, present at every level the node exists.PyCallableParameter.idis<callable-id>@formal_in:<i>for positioni, the level-4 vertex that carries it. The@rule now lives once inschema/ids.py:global_ordinal;IdentityMap.global_idand the projector delegate to it. One stamp pass runs at the end of each body emitter (L1, L3, L4).Additive.
schema_versionand the graph contract unchanged.Gates:
pytest474 passed, 8 skipped. L1⊆L2⊆L3⊆L4 on a fixture. Diff against 1.4.0 output on the same fixture: onlyidkeys added. New tests: L1 stamp, L3 body-id/merge-key parity, L4parameters[i].id == body["@formal_in:i"].idwithof == name.