Alert Unit Tests Fail.

[DeathRay1977]

The following Unit Tests fail:

./test_darkcoin
Running 73 test cases...
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(126): error in "AlertApplies": check alert.CheckSignature() failed
test/alert_tests.cpp(129): error in "AlertApplies": check alerts[0].AppliesTo(1, "") failed
test/alert_tests.cpp(130): error in "AlertApplies": check alerts[0].AppliesTo(70001, "") failed
test/alert_tests.cpp(131): error in "AlertApplies": check alerts[0].AppliesTo(1, "/Satoshi:11.11.11/") failed
test/alert_tests.cpp(133): error in "AlertApplies": check alerts[1].AppliesTo(1, "/Satoshi:0.1.0/") failed
test/alert_tests.cpp(134): error in "AlertApplies": check alerts[1].AppliesTo(70001, "/Satoshi:0.1.0/") failed
test/alert_tests.cpp(136): error in "AlertApplies": check alerts[2].AppliesTo(1, "/Satoshi:0.1.0/") failed
test/alert_tests.cpp(137): error in "AlertApplies": check alerts[2].AppliesTo(1, "/Satoshi:0.2.0/") failed

*** 15 failures detected in test suite "DarkCoin Test Suite"

I will investigate this and fix as necessary. Please assign issue to me. :-)

[darkcoinproject]

Hmm, it won't let me assign you without giving you direct access to the repo. So go ahead and work on it, we won't be stepping on each other. When you're done just do a pull request and I'll merge it :-) .
Thanks for the help!

[DeathRay1977]

Cool... Leave it with me... :-)

[DeathRay1977]

Further to this issue. I did some debugging and it seems that darkcoin/src/test/data/alertTests contains serialzed alerts that are saved with a signature that was generated using a different private key. It does not match up to the public keys that are hard coded in alert.cpp:

static const char* pszMainKey = "048240a8748a80a286b270ba126705ced4f2ce5a7847b3610ea3c06513150dade2a8512ed5ea86320824683fc0818f0ac019214973e677acd1244f6d0571fc5103";
static const char* pszTestKey = "04517d8a699cb43d3938d7b24faaff7cda448ca4ea267723ba614784de661949bf632d6304316b244646dea079735b9a6fc4af804efb4752075b9fe2245e14e412";

The way forward would be to regenerate alertTests using the correct private key to sign them (the private key that goes along with pszTestKey above). I don't have access to that private key and so I cannot fix this issue.

[darkcoinproject]

If you want to work on this issue you could create the code to generate the serialized alert file ,then I'll run it after the merge to fix the unit tests. To determine that your code works just use the rpc command "makekeypair" and change out the keys locally. Let me know if you want to handle this, otherwise I'll add it to my list

[DeathRay1977]

Sure. No problem. Leave it with me.

[DeathRay1977]

This can now be closed. A fix was added as a pull request this morning.

[darkcoinproject]

Thanks a bunch, works great!

[DeathRay1977]

No problems. I should have some spare time to do some more next week.