fix: user manager fix - #6854
Merged
Merged
Conversation
Shivam-nagar23
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
October 17, 2025 09:35
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes user authorization logic for chart group entities in the user management system. The fix addresses a scenario where chart group authorization was not properly handled when role groups were also being assigned.
- Updated the authorization logic for chart group entities to properly handle cases with role groups
- Added conditional logic to defer chart group authorization to role group validation when both are present
- Improved code comments to clarify the authorization flow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
kartik-579
approved these changes
Oct 17, 2025
vikramdevtron
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2648
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito
This pull request fixes a bug in the user authorization logic within the UserRestHandler, refining access conditions for chart group entities. The enhancements improve security and functionality in user management, particularly with multiple role filters.