Enable more tests to run on all 3 runtimes, part 13 - #10635
Merged
Conversation
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
2 times, most recently
from
December 9, 2025 19:43
7e3f8f4 to
a45dafc
Compare
grendello
marked this pull request as ready for review
December 10, 2025 15:07
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
December 12, 2025 08:38
1fc2bd5 to
f728327
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
3 times, most recently
from
January 14, 2026 09:58
a6f8ea0 to
f802ad8
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
February 2, 2026 10:04
4a71530 to
e5a3fb0
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
February 4, 2026 09:06
e5a3fb0 to
d305b94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends test coverage in InstallAndRunTests.cs by modifying test methods to run on all three Android runtimes (MonoVM, CoreCLR, and NativeAOT) instead of being limited to specific runtimes. The PR is part of a series (part 13) aimed at improving runtime test coverage.
Changes:
- Converted multiple test methods from [TestCase] attributes to [Values] attributes with AndroidRuntime parameter
- Added runtime-specific package name generation using
PackageUtils.MakePackageName(runtime) - Added
IgnoreUnsupportedConfigurationchecks and runtime-specificAssert.Ignorestatements for known limitations - Created test data generator methods
Get_DotNetRun_DataandGet_SmokeTestBuildAndRunWithSpecialCharacters_Datato generate test combinations
Comments suppressed due to low confidence (1)
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs:448
- Condition is always false because of ... == ....
AndroidRuntime.CoreCLR => null, // CoreCLR explicitly passes a `null` sender
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
2 times, most recently
from
February 5, 2026 08:57
fa9fd76 to
ffa9f47
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
5 times, most recently
from
February 25, 2026 11:16
0cbf89d to
d7ea1ec
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
3 times, most recently
from
March 5, 2026 08:30
9a3581e to
a40eeba
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
4 times, most recently
from
March 11, 2026 07:59
88f92ec to
0286907
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
March 25, 2026 13:01
db1ff4f to
e8e1146
Compare
jonathanpeppers
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily refactors and improves test utility methods and logging for better maintainability and clarity. The most important changes include refactoring how MSBuild warnings are asserted in tests, improving debug logging in marshal method generation, and making test timeouts more maintainable by using a constant.
Test utilities and assertion improvements:
AssertHasNoWarningsandAssertHasSomeWarningsmethods inAssertionExtensions.csto reduce duplication and centralize the logic for asserting the number of MSBuild warnings. Now, both methods delegate to a shared implementation, improving maintainability.using System.Collections.Generic;directive inAssertionExtensions.csto support the refactored methods.Logging improvements:
MarshalMethodsNativeAssemblyGenerator.csto include the native symbol name when generating marshal methods, providing more context for debugging.Test timeout maintainability:
MonoAndroidExportTest.csto use the shared constantInstallAndRunTests.ActivityStartTimeoutInSeconds, improving consistency and ease of configuration. [1] [2]