[xaprepare] Remove dead Step_DetermineAzurePipelinesTestJobs - #11308
Merged
simonrozsival merged 1 commit intoMay 11, 2026
Conversation
This step and its Scenario_DetermineApplicableTests are not referenced by any CI YAML, Makefile target, or .targets file. Dead code removal as part of incremental xaprepare cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused xaprepare scenario/step pair that attempted to infer Azure Pipelines test areas from merge commit file diffs. This is consistent with incremental cleanup of xaprepare’s unused code paths.
Changes:
- Deleted
Step_DetermineAzurePipelinesTestJobs(Azure Pipelines variable setting logic based ongit diffof merge commits). - Deleted
Scenario_DetermineApplicableTests, which only existed to run the above step and adjust program-installation conditions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build-tools/xaprepare/xaprepare/Steps/Step_DetermineAzurePipelinesTestJobs.cs | Removed unused step that computed TestAreas from merge commit changes. |
| build-tools/xaprepare/xaprepare/Scenarios/Scenario_DetermineApplicableTests.cs | Removed unused scenario which invoked the deleted step. |
jonathanpeppers
added
the
ready-to-review
simonrozsival
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes two dead-code files from xaprepare:
Steps/Step_DetermineAzurePipelinesTestJobs.csScenarios/Scenario_DetermineApplicableTests.csNeither class is referenced by any CI YAML, Makefile target,
.targetsfile, or other code outside these two files. TheDetermineApplicableTestsscenario is never invoked.Part of incremental xaprepare cleanup.