Skip to content

[tests] Set xamarin_manifest_needs_updating to false for API 37 - #11367

Merged
jonathanpeppers merged 1 commit into
mainfrom
fix/xamarin-manifest-flag
May 15, 2026
Merged

[tests] Set xamarin_manifest_needs_updating to false for API 37#11367
jonathanpeppers merged 1 commit into
mainfrom
fix/xamarin-manifest-flag

Conversation

@sbomer

@sbomer sbomer commented May 15, 2026

Copy link
Copy Markdown
Member

The Xamarin manifest now includes API 37 entries, so InstallAndroidDependenciesTest should no longer expect failures when using the Xamarin manifest type.

All three runtimes (MonoVM, CoreCLR, NativeAOT) are currently failing on main with:

We didn't expect the Xamarin manifest to have the requested component. If the manifest has been updated, change 'InstallAndroidDependenciesTest.xamarin_manifest_needs_updating' to be 'false'.

Example failing build: Xamarin.Android #14101833

This content was created with assistance from AI.

The Xamarin manifest now includes API 37 entries, so the
InstallAndroidDependenciesTest should no longer expect failures
when using the Xamarin manifest type.

Fixes build failures on main:
https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_build/results?buildId=14101833

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: Claude:claude-opus-4.6-1m
@sbomer
sbomer requested a review from jonathanpeppers as a code owner May 15, 2026 05:50
Copilot AI review requested due to automatic review settings May 15, 2026 05:50
@sbomer
sbomer requested a review from simonrozsival as a code owner May 15, 2026 05:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android dependency installation test expectation now that the Xamarin manifest includes API 37 components.

Changes:

  • Sets xamarin_manifest_needs_updating to false so Xamarin manifest dependency resolution is expected to succeed for API 37.
Show a summary per file
File Description
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs Updates the test guard for Xamarin manifest API 37 availability.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@jonathanpeppers
jonathanpeppers merged commit a747ec9 into main May 15, 2026
6 of 7 checks passed
@jonathanpeppers
jonathanpeppers deleted the fix/xamarin-manifest-flag branch May 15, 2026 13:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants