Tests: rename InstantRunTest to FastDevTest and drop duplicate - #11736
Merged
Conversation
The "Instant Run" name is leftover Android Studio jargon from ~2016 and is misleading: we never implemented the Android Studio Instant Run protocol. These tests exercise our Fast Deployment pipeline (`_BuildApkFastDev` + `_Upload`), which pushes managed assemblies to the on-device override directory so an assembly-only edit skips repackaging/reinstalling the APK. The earlier "Enhanced Fast Dev" path -- which did slice/sideload dex on device -- has been removed, so the InstantRun name is doubly confusing: it suggests behavior we never had, and adjacent behavior we no longer have. Renames: * `InstantRunTest.cs` -> `FastDevTest.cs` * `class InstantRunTest` -> `FastDevTest` * `InstantRunSimpleBuild` -> `FastDevSimpleBuild` * `InstantRunFastDevDexes` -> `FastDevWithEmbeddedDex` (the old name said "FastDev" twice; the test is really about the `android:useEmbeddedDex` manifest attribute interacting with Fast Dev install) * `temp/InstantRunTargetsSkipped_*` -> `temp/FastDevTargetsSkipped_*` * `test-catalog.md` filter alias updated Removed `InstantRunResourceChange`. It performed the exact same `LinearLayout` -> `RelativeLayout` layout edit + reinstall as `SkipFastDevAlreadyInstalledResources`, but only grepped the build log for `_BuildApkFastDev` / `_Upload` target names. The surviving test is strictly stronger: it cracks open `packaged_resources` and asserts the new layout bytes are actually present in the archive, which implies both targets ran. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates device integration tests to reflect the actual feature under test: Fast Deployment (via _BuildApkFastDev + _Upload), replacing the outdated “Instant Run” naming and removing a redundant resource-change test.
Changes:
- Renames the
InstantRunTestfixture and key test methods toFastDev*to match the Fast Deployment pipeline being asserted. - Removes
InstantRunResourceChangeas duplicative of the strongerSkipFastDevAlreadyInstalledResourcestest. - Updates the test-catalog filter alias from
InstantRunTesttoFastDevTest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/MSBuildDeviceIntegration/Tests/FastDevTest.cs | Renames the test fixture/methods to FastDev* and deletes the redundant resource-change test. |
| .github/skills/tests/references/test-catalog.md | Updates the documented filter alias to FullyQualifiedName~FastDevTest and adjusts the description accordingly. |
jonathanpeppers
enabled auto-merge (squash)
June 25, 2026 18:15
simonrozsival
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why rename?
The "Instant Run" name in
tests/MSBuildDeviceIntegration/Tests/InstantRunTest.csis leftover Android Studio jargon from ~2016. We never implemented the Android Studio Instant Run protocol — these tests have always exercised our Fast Deployment pipeline (_BuildApkFastDev+_Upload), which pushes managed assemblies to the on-device override directory so an assembly-only edit can skip repackaging/reinstalling the APK.To make matters worse, the older Enhanced Fast Dev path (which actually did slice/sideload dex on device) was removed. So the
InstantRunname suggests behavior we never had and sits next to behavior we no longer have. Renaming toFastDevmatches the targets the tests actually assert against (_BuildApkFastDev) and the rest of our docs/codebase.InstantRunTest.csFastDevTest.csclass InstantRunTestclass FastDevTestInstantRunSimpleBuildFastDevSimpleBuildInstantRunFastDevDexesFastDevWithEmbeddedDextemp/InstantRunTargetsSkipped_*temp/FastDevTargetsSkipped_*InstantRunFastDevDexesalso said "FastDev" twice — the test isn't really about dexes, it's about Fast Dev install/launch interacting with theandroid:useEmbeddedDexmanifest attribute, soFastDevWithEmbeddedDexdescribes it more honestly..github/skills/tests/references/test-catalog.mdfilter alias was updated to match.Why remove
InstantRunResourceChange?It is fully duplicative of
SkipFastDevAlreadyInstalledResources:InstantRunResourceChange(removed)SkipFastDevAlreadyInstalledResources(kept)LinearLayout→RelativeLayoutinMain.axml_BuildApkFastDev/_Uploadtarget namespackaged_resourceszip and asserts the new layout bytes are actually presentThe kept test is strictly stronger. Anything the removed test could detect (Fast Dev targets running on a resource edit) is implied by the kept test passing.
Test impact
No behavior change in product code — this is rename + delete-one-redundant-test in
tests/.