Disable flaky incremental build timing test - #11793
Merged
simonrozsival merged 2 commits intoJun 29, 2026
Merged
Conversation
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate potential problems with incremental builds
Disable flaky incremental build timing test
Jun 29, 2026
simonrozsival
marked this pull request as ready for review
June 29, 2026 07:37
simonrozsival
approved these changes
Jun 29, 2026
simonrozsival
enabled auto-merge (squash)
June 29, 2026 07:38
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables a known-flaky incremental build test in the Xamarin.Android.Build.Tasks test suite to prevent timing-related failures from obscuring ongoing investigation into incremental build regressions (issue #11792).
Changes:
- Mark
IncrementalBuildTest.BasicApplicationRepetitiveBuildas ignored with an inline reason and link to the tracking issue.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs | Disables a flaky timing-based incremental build test via [Ignore] with a reference to the ongoing investigation. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs:23
- The timing-based assertion in this test only runs for non-NativeAOT (see the
if (runtime != AndroidRuntime.NativeAOT)guard later), but adding a method-level[Ignore]skips all runtimes, including the NativeAOT incremental assertions (_Sign skipped / not skipped). To reduce flakiness without losing NativeAOT coverage, ignore only the non-NativeAOT case(s) inside the test body instead of using the attribute.
[Test]
[Ignore ("Flaky timing-based test. Disabled while investigating incremental build regressions. See: https://github.com/dotnet/android/issues/11792")]
public void BasicApplicationRepetitiveBuild ([Values (AndroidRuntime.CoreCLR, AndroidRuntime.NativeAOT)] AndroidRuntime runtime)
{
bool isRelease = runtime == AndroidRuntime.NativeAOT;
if (IgnoreUnsupportedConfiguration (runtime, release: isRelease)) {
- Files reviewed: 1/1 changed files
- Comments generated: 0
jonathanpeppers
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incremental build suite has a known flaky test that can fail when machine load makes the second build slower than the first, obscuring whether the failure is a real incrementality regression. This change temporarily removes that noise so follow-up investigation can focus on the underlying behavior.
Test change
IncrementalBuildTest.BasicApplicationRepetitiveBuildas ignored.Scope
What changed