Skip to content

Disable flaky incremental build timing test - #11793

Merged
simonrozsival merged 2 commits into
mainfrom
copilot/investigate-incremental-build-issues
Jun 29, 2026
Merged

Disable flaky incremental build timing test#11793
simonrozsival merged 2 commits into
mainfrom
copilot/investigate-incremental-build-issues

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The incremental build suite has a known flaky test that can fail when machine load makes the second build slower than the first, obscuring whether the failure is a real incrementality regression. This change temporarily removes that noise so follow-up investigation can focus on the underlying behavior.

  • Test change

    • Mark IncrementalBuildTest.BasicApplicationRepetitiveBuild as ignored.
    • Add an inline reason pointing to the ongoing incremental-build investigation.
  • Scope

    • No production build logic changes.
    • No changes to incremental build behavior itself; this only suppresses the timing-based assertion for now.
  • What changed

    [Test]
    [Ignore ("Flaky timing-based test. Disabled while investigating incremental build regressions. See: https://github.com/dotnet/android/issues/11792")]
    public void BasicApplicationRepetitiveBuild ([Values (AndroidRuntime.CoreCLR, AndroidRuntime.NativeAOT)] AndroidRuntime runtime)

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate potential problems with incremental builds Disable flaky incremental build timing test Jun 29, 2026
Copilot AI requested a review from simonrozsival June 29, 2026 07:22
@simonrozsival
simonrozsival marked this pull request as ready for review June 29, 2026 07:37
Copilot AI review requested due to automatic review settings June 29, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables a known-flaky incremental build test in the Xamarin.Android.Build.Tasks test suite to prevent timing-related failures from obscuring ongoing investigation into incremental build regressions (issue #11792).

Changes:

  • Mark IncrementalBuildTest.BasicApplicationRepetitiveBuild as ignored with an inline reason and link to the tracking issue.
Show a summary per file
File Description
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs Disables a flaky timing-based incremental build test via [Ignore] with a reference to the ongoing investigation.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs:23

  • The timing-based assertion in this test only runs for non-NativeAOT (see the if (runtime != AndroidRuntime.NativeAOT) guard later), but adding a method-level [Ignore] skips all runtimes, including the NativeAOT incremental assertions (_Sign skipped / not skipped). To reduce flakiness without losing NativeAOT coverage, ignore only the non-NativeAOT case(s) inside the test body instead of using the attribute.
		[Test]
		[Ignore ("Flaky timing-based test. Disabled while investigating incremental build regressions. See: https://github.com/dotnet/android/issues/11792")]
		public void BasicApplicationRepetitiveBuild ([Values (AndroidRuntime.CoreCLR, AndroidRuntime.NativeAOT)] AndroidRuntime runtime)
		{
			bool isRelease = runtime == AndroidRuntime.NativeAOT;
			if (IgnoreUnsupportedConfiguration (runtime, release: isRelease)) {
  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@simonrozsival simonrozsival added copilot `copilot-cli` or other AIs were used to author this ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). labels Jun 29, 2026
@simonrozsival
simonrozsival merged commit d12b00d into main Jun 29, 2026
41 checks passed
@simonrozsival
simonrozsival deleted the copilot/investigate-incremental-build-issues branch June 29, 2026 12:53
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

copilot `copilot-cli` or other AIs were used to author this flaky-tests ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants