Skip to content

[tests] Ignore MarshalMethodsAppRuns on CoreCLR - #12213

Merged
jonathanpeppers merged 3 commits into
mainfrom
jonathanpeppers-fix-marshal-methods-runtime-test
Jul 23, 2026
Merged

[tests] Ignore MarshalMethodsAppRuns on CoreCLR#12213
jonathanpeppers merged 3 commits into
mainfrom
jonathanpeppers-fix-marshal-methods-runtime-test

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Jul 23, 2026

Copy link
Copy Markdown
Member

Description

MarshalMethodsAppRuns(CoreCLR) repeatedly crashes in Java_mono_android_TypeManager_n_activate across unrelated CI builds because marshal methods are not yet working on CoreCLR.

Ignore the test for now while keeping it in place so CoreCLR coverage can be restored when the runtime support is ready. NativeAOT was already skipped by the test as unsupported.

Related to #12206. The issue should remain open to track restoring the test.

  • Useful description of why the change is necessary.
  • Links to the related issue.
  • Unit tests: not applicable; this change temporarily ignores a failing device test.

Copilot AI review requested due to automatic review settings July 23, 2026 14:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MSBuild device integration regression test MarshalMethodsAppRuns to run only on the supported MonoVM runtime now that marshal methods are MonoVM-only, avoiding intermittent CoreCLR crashes seen in CI.

Changes:

  • Remove CoreCLR/NativeAOT parameterization from MarshalMethodsAppRuns.
  • Force the test project runtime to AndroidRuntime.MonoVM and delete CoreCLR/NativeAOT-specific branching.

@jonathanpeppers jonathanpeppers changed the title [tests] Run MarshalMethodsAppRuns only on MonoVM [tests] Ignore unsupported MarshalMethodsAppRuns test Jul 23, 2026
Marshal methods are only supported with MonoVM, which is no longer part
of the main runtime test matrix. Ignore the CoreCLR and NativeAOT cases
until supported coverage is available.

Refs #12206

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 36bca154-2e3f-4ea0-8159-335cafa8dbe3
@jonathanpeppers
jonathanpeppers force-pushed the jonathanpeppers-fix-marshal-methods-runtime-test branch from 919fb63 to 7621dbf Compare July 23, 2026 14:45
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 36bca154-2e3f-4ea0-8159-335cafa8dbe3
@jonathanpeppers jonathanpeppers changed the title [tests] Ignore unsupported MarshalMethodsAppRuns test [tests] Ignore MarshalMethodsAppRuns on CoreCLR Jul 23, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 36bca154-2e3f-4ea0-8159-335cafa8dbe3
@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Jul 23, 2026

@jonathanpeppers jonathanpeppers left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is ignored, merging:

Image

@jonathanpeppers
jonathanpeppers merged commit 1643fc8 into main Jul 23, 2026
42 of 44 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-fix-marshal-methods-runtime-test branch July 23, 2026 18:00
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants