[Mono.Android] Move Android documentation notices - #12220
Merged
jonathanpeppers merged 4 commits intoJul 24, 2026
Conversation
Android documentation attribution was appended to every generated XML documentation member. This exposed a legal disclaimer throughout IntelliSense and obscured useful API documentation. Stop passing the production copyright file to java-source-utils. Retain CopyrightFile support for binding projects with a dedicated test fixture, and place the Android documentation attribution and license texts in the third-party notices shipped with the product. Fixes #3788 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce04439e-2ebe-4633-986f-65bf47a22f05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #3788 by removing the Android documentation attribution/legal notice that was being injected into every generated XML documentation member (and thus exposed in IntelliSense), and instead relocating the attribution and associated license texts into the product’s third-party notices while keeping CopyrightFile support for binding projects.
Changes:
- Add an “Android API documentation” entry to
THIRD-PARTY-NOTICES.TXTand include the required attribution + Apache 2.0 / GPLv2+Classpath / ICU / W3C license texts. - Stop passing
--doc-copyright(and the Mono.Androidjavadoc-copyright.xml) when generating Mono.Android’s javadoc-derived XML. - Update tests to use a local test
javadoc-copyright.xmlresource to continue validatingCopyrightFileimport behavior for bindings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| THIRD-PARTY-NOTICES.TXT | Adds a dedicated Android API documentation notice section and embeds the relevant license texts. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Xamarin.Android.Build.Tests.csproj | Removes embedding the Mono.Android copyright XML into the test assembly. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Resources/javadoc-copyright.xml | Adds a test-only copyright XML snippet used by CopyrightFile tests. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BindingBuildTest.cs | Updates the JavaSourceJar test to validate the new test notice content is imported. |
| src/Mono.Android/Mono.Android.targets | Removes default --doc-copyright arguments so generated docs no longer include the notice everywhere. |
| src/Mono.Android/javadoc-copyright.xml | Removes the previously injected Android Open Source Project attribution snippet. |
Use the canonical FSF wording for GPLv2 section 3(c) instead of the typo present in Android's hosted copy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce04439e-2ebe-4633-986f-65bf47a22f05
Keep the existing trailing blank line unchanged after correcting the GPLv2 text. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce04439e-2ebe-4633-986f-65bf47a22f05
Avoid changing the existing trailing spacing in the third-party notices file. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce04439e-2ebe-4633-986f-65bf47a22f05
jonathanpeppers
enabled auto-merge (squash)
July 24, 2026 13:22
jonathanpeppers
added
the
ready-to-review
rolfbjarne
approved these changes
Jul 24, 2026
jonathanpeppers
deleted the
jonathanpeppers-fix-intellisense-legal-notice
branch
July 24, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include:Android documentation attribution is currently appended to every generated XML documentation member. This exposes a legal disclaimer throughout IntelliSense and obscures useful API documentation.
Stop injecting the production copyright file into generated member documentation while retaining
CopyrightFilesupport for binding projects. Move the Android documentation attribution and applicable Apache 2.0, GPLv2 with Classpath Exception, ICU, and W3C license texts into the third-party notices shipped with the product.The focused
JavaSourceJartests pass for CoreCLR and NativeAOT.Fixes #3788