[devops] Make the API diff pipeline use a pr: trigger. - #25284
Merged
Conversation
Unfortunately Azure DevOps doesn't properly report GitHub checks for pipelines triggered by another pipeline, when that other pipeline was triggered from a pr trigger. So go back to triggering the API diff pipeline using a pr: trigger. This effectively reverts #21880 ("[CI] Make the API diff be triggered as soon as the config of the build is done.") References: * https://stackoverflow.com/questions/78443654/reporting-stage-statuses-to-github-for-pipeline-triggered-by-another-pipeline
Member
Author
|
This is the same as #25238, just with the correct target branch. Merging right away, since the original PR passed, was approved, and is identical to this one. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches the PR API diff pipeline back to using an Azure DevOps pr: trigger (instead of being triggered via a pipeline resource), in order to ensure GitHub check reporting works correctly for PRs.
Changes:
- Replace the pipeline-resource-based trigger with an explicit
pr:trigger forrun-pr-api-diff.yml, including path exclusions to avoid running on doc-only changes. - Remove a trailing blank line at the end of the top-level
Makefile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/devops/automation/run-pr-api-diff.yml | Reverts PR API diff pipeline to a direct PR trigger with path exclusions. |
| Makefile | Removes trailing whitespace/blank line at EOF. |
This was referenced May 6, 2026
rolfbjarne
added a commit
that referenced
this pull request
May 6, 2026
…25344) * [devops] Make the tests pipeline use a pr: trigger. (#25239) * [devops] Make the API diff pipeline use a pr: trigger. (#25284) * [devops] Fix PR latest-commit detection (#25231) * [devops] Add a timeout to the 'Publish to Artifact Services Drop' step. (#25210) * [devops] Disable implicit CI triggers on xamarin-macios-pr pipeline (#25211) * [devops] Remove the branch-based trigger for pull requests. (#25182) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
rolfbjarne
added a commit
that referenced
this pull request
May 7, 2026
…25345) * [devops] Make the tests pipeline use a pr: trigger. (#25239) * [devops] Make the API diff pipeline use a pr: trigger. (#25284) * [devops] Fix PR latest-commit detection (#25231) * [devops] Disable implicit CI triggers on xamarin-macios-pr pipeline (#25211) * [devops] Remove the branch-based trigger for pull requests. (#25182) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately Azure DevOps doesn't properly report GitHub checks for pipelines
triggered by another pipeline, when that other pipeline was triggered from a
pr trigger.
So go back to triggering the API diff pipeline using a pr: trigger.
This effectively reverts #21880 ("[CI] Make the API diff be triggered as soon as the config of the build is done.")
References: