[runtime] Show the error code if calling coreclr_initialize fails. - #25544
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to improve diagnostics for CoreCLR startup failures by logging the coreclr_initialize return code before VM initialization reports failure.
Changes:
- Adds a failure-path log message after
coreclr_initializereturns a non-zero value.
| LOG_CORECLR (stderr, "xamarin_vm_initialize (%i, %p, %p): rv: %i domainId: %i handle: %p\n", combinedPropertyCount, combinedPropertyKeys, combinedPropertyValues, rv, coreclr_domainId, coreclr_handle); | ||
|
|
||
| if (rv != 0) { | ||
| LOG (PRODUCT ": The call to 'coreclr_initialize' failed: %i (%p)\n", rv, rv); |
| LOG_CORECLR (stderr, "xamarin_vm_initialize (%i, %p, %p): rv: %i domainId: %i handle: %p\n", combinedPropertyCount, combinedPropertyKeys, combinedPropertyValues, rv, coreclr_domainId, coreclr_handle); | ||
|
|
||
| if (rv != 0) { | ||
| LOG (PRODUCT ": The call to 'coreclr_initialize' failed: %i (%p)\n", rv, rv); |
✅ [PR Build #64d4b14] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #64d4b14] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #64d4b14] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #64d4b14] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 193 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
No description provided.