Skip to content

[docs] Improve XML docs for ModelAttribute - #25964

Merged
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/xmldocs-019-modelattribute
Jul 8, 2026
Merged

[docs] Improve XML docs for ModelAttribute#25964
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/xmldocs-019-modelattribute

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jul 7, 2026

Copy link
Copy Markdown
Member

Improve XML documentation for the ModelAttribute type:

  • Replace 'To be added.' placeholders with meaningful descriptions
  • Remove empty <remarks> nodes
  • Remove redundant docs/api/Foundation/ModelAttribute.xml (docs are now inline in source)
  • Document Name property

🤖 Pull request created by Copilot

Inline the XML docs from the include file and remove the
external documentation file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 7, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Foundation.ModelAttribute API documentation by moving documentation inline into the source file and removing the legacy external XML doc file.

Changes:

  • Replaced the <include ...ModelAttribute.xml /> reference with inline <summary>/<remarks> documentation in ModelAttribute.cs.
  • Improved constructor and Name property XML docs (removing “To be added.” placeholders).
  • Deleted docs/api/Foundation/ModelAttribute.xml since the docs are now inline.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Foundation/ModelAttribute.cs Adds inline XML docs for ModelAttribute and its members.
docs/api/Foundation/ModelAttribute.xml Removes the redundant external XML documentation file.

Comment thread src/Foundation/ModelAttribute.cs Outdated
Comment thread src/Foundation/ModelAttribute.cs
dalexsoto
dalexsoto previously approved these changes Jul 7, 2026
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 8, 2026 11:36
@rolfbjarne
rolfbjarne disabled auto-merge July 8, 2026 11:36
@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 8, 2026 11:37
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 59b4252ba2cc654533cef5e0407d9c54a1f804d7 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #59b4252] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 199 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 59b4252ba2cc654533cef5e0407d9c54a1f804d7 [PR build]

@rolfbjarne
rolfbjarne merged commit 52094e0 into main Jul 8, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/xmldocs-019-modelattribute branch July 8, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants