[ObjCRuntime] Use Type.GetMemberWithSameMetadataDefinitionAs to find closed generic members. Fixes #18355 - #26143

rolfbjarne · 2026-07-16T17:40:59Z

Replace the loop in Runtime.FindClosedMethod that iterated over all methods on the closed type comparing metadata tokens with a single call to Type.GetMemberWithSameMetadataDefinitionAs, which performs exactly this lookup natively and avoids materializing the full method list.

This speeds up finding closed generic members in the dynamic registrar.

Fixes #18355

🤖 Pull request created by Copilot

…closed generic members Replace the loop in Runtime.FindClosedMethod that iterated over all methods on the closed type comparing metadata tokens with a single call to Type.GetMemberWithSameMetadataDefinitionAs, which does exactly this lookup natively and avoids materializing the full method list. Fixes #18355 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR improves performance in the dynamic registrar by optimizing how closed generic methods are located at runtime. It replaces a full method enumeration (and metadata token comparisons) with a direct lookup using Type.GetMemberWithSameMetadataDefinitionAs, avoiding materializing all methods on the closed type.

Changes:

Replace closed_type.GetMethods(...DeclaredOnly) iteration + MetadataToken comparisons with closed_type.GetMemberWithSameMetadataDefinitionAs(open_method).
Update the associated ILLink (IL2070) suppression comment to reflect the new API call.

…use-type-getmemberwithsamemetadatadefini-5d5fa8

…amemetadatadefini-5d5fa8

vs-mobiletools-engineering-service2 · 2026-07-27T18:37:23Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c7be75886fcc7430b813a10634b5df6a64409770 [PR build]

vs-mobiletools-engineering-service2 · 2026-07-28T20:23:48Z

🚀 [CI Build #c7be758] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 203 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: c7be75886fcc7430b813a10634b5df6a64409770 [PR build]

rolfbjarne added the copilot label Jul 16, 2026

rolfbjarne requested a review from Copilot July 16, 2026 19:17

Copilot started reviewing on behalf of rolfbjarne July 16, 2026 19:17 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes