Skip to content

[CryptoTokenKit] Update bindings up to Xcode 27.0 Beta 3 - #26156

Merged
dalexsoto merged 1 commit into
xcode27.0from
dev/alex/xc27-CryptoTokenKit
Jul 17, 2026
Merged

[CryptoTokenKit] Update bindings up to Xcode 27.0 Beta 3#26156
dalexsoto merged 1 commit into
xcode27.0from
dev/alex/xc27-CryptoTokenKit

Conversation

@dalexsoto

Copy link
Copy Markdown
Member

Summary

  • Bind TKErrorCode.InvalidatedDeviceKey with the native value -10.
  • Remove the resolved CryptoTokenKit xtro todo files for iOS, tvOS, macOS, and Mac Catalyst.
  • Update the existing CryptoTokenKit documentation known-failure baseline.

Validation

  • make world before and after the binding change
  • Clean xtro generation/classification: sanity passed on all platforms
  • Clean Cecil run: 112 passed, 4 skipped
  • Clean AppSizeTest run: 16 expected skips under beta Xcode, 0 failures
  • iOS 27 introspection: 44/44 passed
  • tvOS 27 introspection: 43/43 passed
  • macOS introspection: 32/32 passed, 2 latest-OS checks ignored
  • Mac Catalyst: all 14 non-constructor fixtures passed (36 tests, 4 expected ignores); the full constructor sweep is locally blocked by the known unsigned-host TCC abort in CoreLocationUI.CLLocationButton, unrelated to this numeric enum binding

Bind TKErrorCodeInvalidatedDeviceKey as TKErrorCode.InvalidatedDeviceKey with its native value of -10 across iOS, tvOS, macOS, and Mac Catalyst.

Remove the resolved xtro todo files and add the new enum field to the existing CryptoTokenKit documentation known-failure baseline.

Validated with full make world rebuilds, clean xtro and Cecil runs, the AppSizeTest suite, and introspection on iOS, tvOS, macOS, and all non-TCC-blocked Mac Catalyst fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f5db1a20-7d79-46bf-863a-c0524aa86c0e
Copilot AI review requested due to automatic review settings July 17, 2026 03:10
@dalexsoto dalexsoto added this to the xcode27 milestone Jul 17, 2026
@dalexsoto
dalexsoto requested a review from rolfbjarne July 17, 2026 03:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CryptoTokenKit binding surface to match Xcode 27.0 Beta 3 by adding the missing TKErrorCode value, cleaning up resolved xtro annotations, and aligning the documentation baseline for Cecil docs validation.

Changes:

  • Added TKErrorCode.InvalidatedDeviceKey = -10 to the CryptoTokenKit bindings.
  • Removed resolved xtro-sharpie .todo entries for CryptoTokenKit across iOS/tvOS/macOS/Mac Catalyst.
  • Updated Documentation.KnownFailures.txt to include the new enum field entry.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/cryptotokenkit.cs Adds the missing TKErrorCode.InvalidatedDeviceKey enum value with native value -10.
tests/xtro-sharpie/api-annotations-dotnet/iOS-CryptoTokenKit.todo Removes the resolved xtro todo entry for the missing enum value.
tests/xtro-sharpie/api-annotations-dotnet/tvOS-CryptoTokenKit.todo Removes the resolved xtro todo entry for the missing enum value.
tests/xtro-sharpie/api-annotations-dotnet/macOS-CryptoTokenKit.todo Removes the resolved xtro todo entry for the missing enum value.
tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CryptoTokenKit.todo Removes the resolved xtro todo entry for the missing enum value.
tests/cecil-tests/Documentation.KnownFailures.txt Adds the new enum field to the documentation known-failure baseline.

@dalexsoto
dalexsoto enabled auto-merge (squash) July 17, 2026 05:19
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8f5162fefbceec393ad39a65cda855a47c056684 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #8f5162f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 195 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download
⚠️ Tests on macOS Golden Gate (27): Tests skipped, incorrect beta version. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 8f5162fefbceec393ad39a65cda855a47c056684 [PR build]

@dalexsoto
dalexsoto merged commit 1cb9c4b into xcode27.0 Jul 17, 2026
56 checks passed
@dalexsoto
dalexsoto deleted the dev/alex/xc27-CryptoTokenKit branch July 17, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants