[runtime] Link away entry assembly registration. Fixes #10457 - #26261
Conversation
Guard the native RegisterEntryAssembly callback with the dynamic-registration feature switch so ILLink can remove the managed implementation when the dynamic registrar is unavailable. Enable the linker test on every platform and key its expectation to Runtime.DynamicRegistrationSupported. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 740008fb-1aed-43f9-b15f-df999d024a39
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Enables the existing Runtime_RegisterEntryAssembly linker test across platforms by making the expected presence of ObjCRuntime.Runtime.RegisterEntryAssembly(Assembly) depend on Runtime.DynamicRegistrationSupported (i.e., whether the dynamic registrar is present after trimming), instead of platform/device heuristics.
Changes:
- Remove the simulator-only gate for
Runtime_RegisterEntryAssembly. - Replace platform/device-specific expectations with
!Runtime.DynamicRegistrationSupportedto verify the method is linked away when dynamic registration support is trimmed.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #fa08086] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 203 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. [attempt 2] Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Enable the existing
Runtime_RegisterEntryAssemblylinker test on all platforms.Key the expected method presence to
Runtime.DynamicRegistrationSupported, verifying that bothRegisterEntryAssemblyoverloads are linked away when the dynamic registrar is optimized away.Fixes #10457
🤖 Pull request created by Copilot