Skip to content

[docs] Improve XML docs for HMCharacteristicMetadata, HMCharacteristicProperties, INCallRecord, INIntentResolutionResult, MTKTextureLoaderOptions, GKGridGraph, UIDynamicAnimator, UINavigationBar, CGDataConsumer, ModelNotImplementedException, GKEntity, GKPolygonObstacle, SCNRenderer, UIKitThreadAccessException - #26289

Merged
rolfbjarne merged 16 commits into
mainfrom
dev/rolf/xmldocs-034-batch
Jul 24, 2026

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Improves XML documentation for 14 types:

  • HMCharacteristicMetadata
  • HMCharacteristicProperties
  • INCallRecord
  • INIntentResolutionResult
  • MTKTextureLoaderOptions
  • GKGridGraph
  • UIDynamicAnimator
  • UINavigationBar
  • CGDataConsumer
  • ModelNotImplementedException
  • GKEntity
  • GKPolygonObstacle
  • SCNRenderer
  • UIKitThreadAccessException

Changes:

  • Replaces placeholder 'To be added.' docs with meaningful descriptions
  • Removes empty <remarks> and <returns> nodes
  • Fixes XML doc tag ordering (summary before param)
  • Normalizes XML doc indentation

🤖 Pull request created by Copilot

rolfbjarne and others added 15 commits July 24, 2026 07:54
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
Copilot AI review requested due to automatic review settings July 24, 2026 05:56
@rolfbjarne
rolfbjarne requested a review from dalexsoto as a code owner July 24, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates XML documentation across several Apple-platform binding types in src/ to replace placeholder docs, remove empty nodes, and normalize formatting so the generated API docs are more useful and consistent.

Changes:

  • Removed placeholder <remarks>, <returns>, and <value> nodes and replaced “To be added.” text with more descriptive summaries/params.
  • Adjusted XML doc layout/indentation in multiple files.
  • Updated parameter documentation text for a number of members.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
src/UIKit/UINavigationBar.cs Updates docs for UINavigationBarAppearance title text attribute accessors.
src/UIKit/UIDynamicAnimator.cs Reorders/cleans up docs for behavior add/remove helpers and enumerators.
src/UIKit/UIApplication.cs Updates docs for UIKitThreadAccessException and UIContentSizeCategoryChangedEventArgs.
src/SceneKit/SCNRenderer.cs Replaces placeholder docs for OpenGL-context renderer factory.
src/MetalKit/MTKTextureLoaderOptions.cs Cleans up property docs for texture loader option keys.
src/Intents/INIntentResolutionResult.cs Cleans up docs for common resolution-result factory properties.
src/Intents/INCallRecord.cs Removes placeholder <value>/<remarks> from call record properties.
src/HomeKit/HMCharacteristicProperties.cs Cleans up property docs describing characteristic capabilities.
src/HomeKit/HMCharacteristicMetadata.cs Cleans up docs for metadata unit/format accessors.
src/GameplayKit/GKPolygonObstacle.cs Improves docs for point-based obstacle creation and ctor.
src/GameplayKit/GKGridGraph.cs Improves docs for generic node lookup method.
src/GameplayKit/GKEntity.cs Cleans up docs for component get/remove helpers.
src/Foundation/ModelNotImplementedException.cs Cleans up exception type docs and constructor docs.
src/CoreGraphics/CGDataConsumer.cs Cleans up docs for data-sink constructors (NSData/URL).
Comments suppressed due to low confidence (4)

src/GameplayKit/GKEntity.cs:23

  • The XML doc tag order is inverted here (param before summary) and the summary indentation is inconsistent. Reordering to summary-then-param will match standard C# XML doc formatting.
		/// <param name="componentType">The component type.</param>
		///         <summary>Retrieves the element in <see cref="GameplayKit.GKEntity.Components" /> of the specified <paramref name="componentType" />.</summary>

src/Intents/INIntentResolutionResult.cs:35

  • This is a property, not a method. Referring to it as a "Factory method" in the summary is misleading in generated docs.
		/// <summary>Factory method to create an <see cref="Intents.INIntentResolutionResult" /> object indicating that a value is not required for the parameter.</summary>

src/Intents/INIntentResolutionResult.cs:42

  • This is a property, not a method. Referring to it as a "Factory method" in the summary is misleading in generated docs.
		/// <summary>Factory method to create an <see cref="Intents.INIntentResolutionResult" /> object indicating that the developer's app does not support the parameter.</summary>

src/CoreGraphics/CGDataConsumer.cs:93

  • The XML doc tag order is inverted here (param before summary) and URL should be capitalized consistently.
		/// <param name="url">The url.</param>
		///         <summary>Creates a data sink that saves the data on a file specified by the url.</summary>

Comment thread src/UIKit/UINavigationBar.cs Outdated
Comment thread src/UIKit/UIApplication.cs Outdated
Comment thread src/MetalKit/MTKTextureLoaderOptions.cs Outdated
Comment thread src/HomeKit/HMCharacteristicProperties.cs Outdated
Comment thread src/Foundation/ModelNotImplementedException.cs Outdated
Comment thread src/GameplayKit/GKEntity.cs Outdated
Comment thread src/GameplayKit/GKGridGraph.cs Outdated
Comment thread src/Intents/INIntentResolutionResult.cs Outdated
Comment thread src/Foundation/ModelNotImplementedException.cs Outdated
Comment thread src/UIKit/UIApplication.cs Outdated
- Fix UINavigationBar param-before-summary ordering
- Fix MTKTextureLoaderOptions 'orable' typo
- Fix HMCharacteristicProperties 'support bonjour' → 'supports Bonjour'
- Fix ModelNotImplementedException grammar and summaries
- Fix CGDataConsumer param-before-summary ordering
- Fix GKEntity param-before-summary ordering
- Fix GKGridGraph typeparam description
- Fix INIntentResolutionResult 'Factory method' → property summaries
- Fix UIKitThreadAccessException constructor summary
- Fix UIContentSizeCategoryChangedEventArgs summary

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a37ff16-2fda-4715-8343-f3408ac8c442
@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 24, 2026 06:26
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e4aba3e88f5ecbb0c794a91e3cc089c1a035a1f4 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #e4aba3e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 203 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: e4aba3e88f5ecbb0c794a91e3cc089c1a035a1f4 [PR build]

@rolfbjarne
rolfbjarne merged commit fbe3d00 into main Jul 24, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/xmldocs-034-batch branch July 24, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants