Skip to content

Add null check to CmdStanPyBackend cleanup() function - #2692

Merged
tcuongd merged 1 commit into
facebook:mainfrom
landiinii:main
Oct 18, 2025
Merged

Add null check to CmdStanPyBackend cleanup() function#2692
tcuongd merged 1 commit into
facebook:mainfrom
landiinii:main

Conversation

@landiinii

Copy link
Copy Markdown
Contributor

Adding null check to prevent breaking on cross validation. Complete write up in the issue.

Resolves #2691

@meta-cla

meta-cla Bot commented Oct 9, 2025

Copy link
Copy Markdown

Hi @landiinii!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Oct 9, 2025
@meta-cla

meta-cla Bot commented Oct 9, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@landiinii

Copy link
Copy Markdown
Contributor Author

@tcuongd based on commit history looks like you own this function. Would appreciate a review when you have time. Thanks

@tcuongd
tcuongd merged commit 36769ff into facebook:main Oct 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cross_validate fails cleanup() with constant timeseries

2 participants