0.20.1 inserts wrong framework version condition into project files

[vasily-kirichenko]

I updated Paket to version 0.20.1 (was 0.18), then run paket update.

paket.lock (part of)

Fizzler (1.0.0)
  LinqBridge (>= 1.3.0) - >= net20 < net35
Fizzler.Systems.HtmlAgilityPack (1.0.0)
  Fizzler (>= 1.0.0) - >= net20, >= net35
  HtmlAgilityPack (>= 1.4.6) - >= net20, >= net35
  LinqBridge (>= 1.3.0) - >= net20 < net35

its changes:

A .NET 4.5 C# project with the following paket.references

AutoFixture
Castle.Core
Fizzler
Moq
NUnit
HtmlAgilityPack
Fizzler
Fizzler.Systems.HtmlAgilityPack

has been amended as following

<Choose>
-    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v2.0'">
+    <When Condition="($(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v2.0' Or $(TargetFrameworkVersion) == 'v3.0' Or $(TargetFrameworkVersion) == 'v3.5' Or $(TargetFrameworkVersion) == 'v4.0' Or $(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.5.1' Or $(TargetFrameworkVersion) == 'v4.5.2' Or $(TargetFrameworkVersion) == 'v4.5.3')) Or ($(TargetFrameworkIdentifier) == 'MonoAndroid') Or ($(TargetFrameworkIdentifier) == 'MonoTouch')">
       <ItemGroup>
         <Reference Include="LinqBridge">
           <HintPath>..\..\packages\LinqBridge\lib\net20\LinqBridge.dll</HintPath>
           <Private>True</Private>
           <Paket>True</Paket>
         </Reference>
       </ItemGroup>
     </When>
</Choose>

As a result LinqBridge is actually referenced and conflicting with System.Linq:

error CS0433: The type 'System.Linq.Enumerable' exists in both '...\packages\LinqBridge\lib\net20\LinqBridge.dll' and 'c:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\System.Core.dll'

[forki]

So LinqBridge is tagged as:

LinqBridge (1.3.0) - >= net20 < net35

but it's still installed for .NET 4.x?

[vasily-kirichenko]

Yes, all the packages are on nuget.org.

So LinqBridge is tagged as:
LinqBridge (1.3.0) - >= net20 < net35
but it's still installed for .NET 4.x?

Yes, this is the problem.

[forki]

I tried with:

source https://nuget.org/api/v2

nuget HtmlAgilityPack = 1.4.6
nuget Fizzler.Systems.HtmlAgilityPack

and it gives me:

<Choose>
  <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v2.0' Or $(TargetFrameworkVersion) == 'v3.0')">
    <ItemGroup>
      <Reference Include="LinqBridge">
        <HintPath>..\..\packages\LinqBridge\lib\net20\LinqBridge.dll</HintPath>
        <Private>True</Private>
        <Paket>True</Paket>
      </Reference>
    </ItemGroup>
  </When>
</Choose>

Maybe something else is making trouble.

[vasily-kirichenko]

Add Fizzler package into the mix.

[forki]

Will try. But probably tomorrow.
On Dec 30, 2014 3:12 PM, "Vasily Kirichenko" notifications@github.com
wrote:

Add Fizzler package into the mix.

—
Reply to this email directly or view it on GitHub
#486 (comment).

[vasily-kirichenko]

Thanks!

I've create a minimal repro: https://github.com/vasily-kirichenko/PacketTest

[vasily-kirichenko]

I minimized it even more :)

[forki]

I just run paket update:

that's weird. Everything looks good.

[forki]

ok paket install gives a different result. I can reproduce.

[forki]

I think I understand the issue - will try to fix tomorrow. Thanks for reporting.

[vasily-kirichenko]

Yes, I've got the same result at home machine :( Will retest on the machine at work in a minute.

[vasily-kirichenko]

I've caught it :) Pull the changes from my repo - I removed everything from paket.references, so the project file is clean. Now add

HtmlAgilityPack
Fizzler.Systems.HtmlAgilityPack

into it, then run paket install and the bug will appear (LinqBridge.dll will be referenced).

[vasily-kirichenko]

Thanks!

[forki]

Yep. It's a bug in "install" - "paket update" seems ok.

"install" has to parse/keep the dependency restrictions.
"update" is not affected since it computes everything from scratch.