Skip to content

Support for only using nuget v3 api - #1205

Merged
forki merged 6 commits into
fsprojects:masterfrom
xavierzwirtz:nuget-v3
Nov 11, 2015
Merged

Support for only using nuget v3 api#1205
forki merged 6 commits into
fsprojects:masterfrom
xavierzwirtz:nuget-v3

Conversation

@xavierzwirtz

Copy link
Copy Markdown
Contributor

Can be used by setting source https://api.nuget.org/v3/index.json in paket.dependencies

Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax.

I wrote this so that paket could be used against nuget servers that do not support the v2 api. The v3 api, while still crazy in places, is much easier to implement.

Comment thread paket.dependencies Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah "Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax."

I don't think that's a good idea. we already have parse logic and I think we should take that dependency. We're much faster with fixes if this little parse code is under our control.

@xavierzwirtz

Copy link
Copy Markdown
Contributor Author

I removed the dependency on NuGet.Versioning, it looked like the dependency range syntax had changed radically in v3, but it hasn't changed at all. The v3 api is just handing out valid, but odd, version ranges.

@xavierzwirtz

Copy link
Copy Markdown
Contributor Author

One thing I didn't do, which could be a target for a future pr, is call the v3 apis whenever a v2 api is handed in. That might speed up the typical dependency resolution.

@forki
forki merged commit ac40c17 into fsprojects:master Nov 11, 2015
@xavierzwirtz

Copy link
Copy Markdown
Contributor Author

Wooooo!

@forki

forki commented Nov 11, 2015

Copy link
Copy Markdown
Member

hurray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants