Skip to content

Use the correct request header - #3466

Merged
forki merged 2 commits into
fsprojects:masterfrom
inosik:bugfix/#3458-netcore-push
Jan 2, 2019
Merged

Use the correct request header#3466
forki merged 2 commits into
fsprojects:masterfrom
inosik:bugfix/#3458-netcore-push

Conversation

@inosik

@inosik inosik commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Fixes #3458.

@inosik

inosik commented Jan 2, 2019

Copy link
Copy Markdown
Contributor Author

Hm, crashes at runtime. I'm looking into that.

@inosik

inosik commented Jan 2, 2019

Copy link
Copy Markdown
Contributor Author

This is ready now. I followed an answer on SO to fix the runtime error. I also tried to use the Headers.ContentType property to be safe, but the constructor of System.Net.Http.Headers.MediaTypeHeaderValue doesn't accept the value we pass in.

@forki
forki merged commit 368d536 into fsprojects:master Jan 2, 2019
@inosik
inosik deleted the bugfix/#3458-netcore-push branch January 2, 2019 13:14
@inosik inosik mentioned this pull request Jan 2, 2019
Closed
@haf

haf commented Jan 3, 2019

Copy link
Copy Markdown
Member

This would not have been an issue had you been using HTTP.fs BTW.

@haf

haf commented Jan 3, 2019

Copy link
Copy Markdown
Member

Thank you @inosik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inosik @haf @forki