Proposal: increase process lock trials from 100 to 500 to support dotnet restore on larger solutions - #4203
Merged
forki merged 1 commit intoMar 3, 2023
Conversation
…net restore on larger solutions Alternatively maybe this could be made configurable.
Member
Author
|
Thank you very much for the release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, given how the mechanism works, I don't think a process lock max trial count of 100 could reliably support
dotnet restoreon solutions with more than 100 projects. The downside is potentially longer time until it aborts when there is a left-over lock, which should be rare though.Alternatively maybe this could be made configurable.
Any thoughts?