Fixes an issue where the binding redirect version is picked from the fir... - #422
Conversation
…first file found rather than the highest package version.
There was a problem hiding this comment.
I think the issue is that we're not talking about packages here.
We have libs with conflicting version nos.
There was a problem hiding this comment.
I just followed from the extractedPackages and made the assumption p = package
There was a problem hiding this comment.
yep sorry that's my fault. Should have made it more explicit. p is a library path in this case.
Could you please fix this with your PR? Thanks
There was a problem hiding this comment.
all of it or just my changes?
There was a problem hiding this comment.
No it's just in the lines you touched.
|
@isaacabraham could you please review this one? Thanks |
There was a problem hiding this comment.
Can you adjust the casing of library to Library.
Fixes an issue where the binding redirect version is picked from the fir...
|
Thanks for fixing this. |
3 participants
...st file found rather than the highest package version.
This fixes was the issue I had with #421