Merged
Conversation
Author
|
Yes that is at least what it should do conceptually, since not every buffer update should be reported. I can try to achieve the same without the dependency, it will be just a bit hairy. |
Member
|
just dump the hairy parts into Utils.fs like we all do ;-) |
Author
|
ok :-) |
Member
|
is this done? |
Author
|
it's done now, I just added upload speed and completion percentage |
Member
|
wow cool. could you please remove the ol UploadFileAsMultipart? |
Member
|
mhm. I just merged it and tried it. It didn't show any progress at all.
|
Member
|
@kfrie any ideas? |
Author
|
@forki the sample operator was blocked by |
Member
|
I can't reopen. But you can send a new pull request. And many thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should work. Not so sure about the dependency on
FSharp.Control.Reactivebut a sampling operator is nice for this