Skip to content

Paket should keep paket.dependencies as stable as possible - #802

Merged
forki merged 3 commits into
masterfrom
depsfile
Apr 30, 2015
Merged

Paket should keep paket.dependencies as stable as possible#802
forki merged 3 commits into
masterfrom
depsfile

Conversation

@forki

@forki forki commented Apr 29, 2015

Copy link
Copy Markdown
Member

Idea:

Instead of serializing the Dependencies file from the already parsed information we always modify the text and reparse it. Maybe not the best style, but it keep comments and everything in place.

fixes #780, #731

This needs a lot of testing. Especially the convert-from-nuget stuff (cc @theimowski)

/cc @matthid, @cjbhaines, @mexx, @inosik , @haf

Comment thread src/Paket.Core/DependenciesFile.fs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text representation have to be updated in this case.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups. correct.

Writing a test since this is uncovered.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 93ca6f8

@theimowski

Copy link
Copy Markdown
Member

I'll do some testing on Friday

@theimowski theimowski closed this Apr 29, 2015
@theimowski theimowski reopened this Apr 29, 2015
@forki

forki commented Apr 29, 2015

Copy link
Copy Markdown
Member Author

huh. I accidentally realigned the whole file. reverting that

@forki
forki merged commit a062fcc into master Apr 30, 2015
@forki

forki commented Apr 30, 2015

Copy link
Copy Markdown
Member Author

it's in 1.3.0-alpha001

@theimowski

Copy link
Copy Markdown
Member

I think dependenciesFile is a good candidate for Property-Based round-trip test (parse, format, compare). Would need better tracking of comments/ custom code and similar stuff tho.

@forki

forki commented Apr 30, 2015

Copy link
Copy Markdown
Member Author

would love to see that.

2015-04-30 21:07 GMT+02:00 Tomasz Heimowski notifications@github.com:

I think dependenciesFile is a good candidate for Property-Based
round-trip test (parse, format, compare). Would need better tracking of
comments/ custom code and similar stuff tho.


Reply to this email directly or view it on GitHub
#802 (comment).

@theimowski

Copy link
Copy Markdown
Member

changes in NugetConver look ok - tested on a simple scenario, accidently also found a bug in the convert logic itself - fix in #804

@forki

forki commented Apr 30, 2015

Copy link
Copy Markdown
Member Author

so ready to release?

@theimowski

Copy link
Copy Markdown
Member

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paket Update messes with sources in paket.dependencies

3 participants