Skip to content

Get version requirements from paket.lock - #924

Merged
forki merged 7 commits into
fsprojects:masterfrom
inosik:pack/lock-versions
Jul 21, 2015
Merged

Get version requirements from paket.lock#924
forki merged 7 commits into
fsprojects:masterfrom
inosik:pack/lock-versions

Conversation

@inosik

@inosik inosik commented Jul 16, 2015

Copy link
Copy Markdown
Contributor

Addresses #901.

This allows us to get the version requirements from paket.lock instead of paket.dependencies. That means we then require the specific version (version="[x.y.z]"), which is resolved right now. To use this, just issue paket pack [...] lock-dependencies on the command line.

What do you say? Should I add some tests or maybe documentation?

@forki

forki commented Jul 19, 2015

Copy link
Copy Markdown
Member

could you please create small docs which show (maybe in a table) what version requirement we create for which paket.lock version. Maybe we can switch to the locked versions completely.

@inosik
inosik force-pushed the pack/lock-versions branch from d46181a to c155efb Compare July 19, 2015 12:07
@inosik

inosik commented Jul 19, 2015

Copy link
Copy Markdown
Contributor Author

Maybe we can switch to the locked versions completely.

You mean to always take the constraints from paket.lock? I actually like the default behavior. And it completely makes sense, if the upstream packages follow SemVer, of course.

@inosik
inosik force-pushed the pack/lock-versions branch from c155efb to 5bfb9bd Compare July 19, 2015 13:10
@forki

forki commented Jul 19, 2015

Copy link
Copy Markdown
Member

So this should be a per package decision?
On Jul 19, 2015 15:05, "Ilja Nosik" notifications@github.com wrote:

Maybe we can switch to the locked versions completely.

You mean to always take the constraints from paket.lock? I actually like
the default behavior. And it completely makes sense, if the upstream
packages follow SemVer, of course.

—
Reply to this email directly or view it on GitHub
#924 (comment).

@inosik

inosik commented Jul 19, 2015

Copy link
Copy Markdown
Contributor Author

I mean we should keep the default behavior, but if one runs paket pack lock-dependencies, all the dependencies of the resulting package(s) should be locked.

I thought you mean to drop the current behavior (taking the constraints from paket.dependencies).

inosik added 6 commits July 20, 2015 20:54
@inosik
Update findDependencies
e0af296 
Allow getting the version requirements of dependencies from `paket.lock`
by adding an additional parameter. Also add this parameter all the way
up to `PublicAPI.Pack`.
@inosik
Fail with a better error message
ae6d8bf 
If we fail to find the requirement for a package, throw an exception
instead of throwing an `KeyNotFoundException`.
@inosik
Lock inter-project dependencies
17a1c92
@inosik
Add lock-dependencies parameter
c388d05 
Add the parameter to the PackArgs-Type and pass it.
@inosik
Add docs for paket pack command
33cd652
@inosik
Add links to documentation of Paket-files
ee7a3d3
@inosik
inosik force-pushed the pack/lock-versions branch from 5bfb9bd to ee7a3d3 Compare July 20, 2015 18:55
@inosik

inosik commented Jul 20, 2015

Copy link
Copy Markdown
Contributor Author

I think I'm done here. Maybe somebody could provide a real-world paket.dependencies, paket.lock and paket.references, to show a better example in the docs?

@forki
forki merged commit 5f02389 into fsprojects:master Jul 21, 2015
@forki

forki commented Jul 21, 2015

Copy link
Copy Markdown
Member

thanks.

@inosik
inosik deleted the pack/lock-versions branch July 21, 2015 17:29
@inosik inosik mentioned this pull request Jul 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inosik @forki