Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

BucketNotification.create() does not check if a topic is provided #616

Closed
#617
Closed
BucketNotification.create() does not check if a topic is provided#616
#617
Assignees
cojenco
Labels
api: storageIssues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@cojenco
cojenco
opened on Oct 6, 2021

A PubSub topic (topic name) is required to insert a BucketNotification according to the JSON API.

Currently the library is not checking in BucketNotification.create() if a topic name is set or not. topic_name=None is incorrectly interpolated to "//pubsub.googleapis.com/projects/<project-identifier>/topics/None"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions