rangeTest: Fix signed-ness of types - #5
Merged
Conversation
Contributor
Author
|
Ping? |
On some architectures types like CChar are signed whereas the use previously assumed they were unsigned. Fix this by relying on Bounded instances where possible.
This reverts commit 2117e38. We no longer assume that C types are unsigned.
Contributor
Author
|
How's this look? |
rrnewton
added a commit
that referenced
this pull request
Aug 22, 2014
rangeTest: Fix signed-ness of types
Member
|
Looks good for me, very sorry for delay. |
Contributor
Contributor
Author
|
@thomie very good catch, sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some architectures types like CChar are signed whereas the use previously
assumed they were unsigned. Fix this by relying on Bounded instances where
possible.