Use unsafeWithForeignPtr when available - #325
Merged
Merged
Conversation
Contributor
|
@bgamari could you please fix failed builds and rebase? |
It turns out that all uses of withForeignPtr can safely use unsafeWithForeignPtr.
bgamari
force-pushed
the
wip/unsafeWithForeignPtr
branch
from
April 2, 2021 19:33
07f7fcb to
b7149b4
Compare
Bodigrim
approved these changes
Apr 2, 2021
Bodigrim
left a comment
Bodigrim
left a comment
Contributor
There was a problem hiding this comment.
This does not seem to fix a performance regression in GHC 9.0, but is useful nevertheless. Thanks!
|
Thanks @bgamari! |
Lysxia
approved these changes
Apr 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that all uses of
withForeignPtrcan safely useunsafeWithForeignPtr.I believe that this should resolve the regression noted in
GHC #19557
although I am still benchmarking